fix: allow for whitespace in snippets declaration #2366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close sveltejs/svelte#11478
The problem was that the generic generation was relying on the start position of
typeAnnotation
+ 1. But if there are whytespaces this is not correct and the generate type is wrongSnippet<[: string]>
. However inside the firsttypeAnnotation
there's always a secondtypeAnnotation
field which only includes the actual types (at least from what i was able to see, i wasn't able to find a type that doesn't generate at least two level deepstypeAnnotation
).This seems to work fine but give it a good look since it's the first time i'm working in this repo.