(fix) support then/catch shorthands #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1283
Added in Svelte 3.41
Tests are failing because there's a check in Svelte now which errors when someone writes something like
on:(:last without a letter afterwards). We should probably try to implement some kind of more forgiving AST traversal mode in Svelte before bumping the Svelte version here -> #1177 .Update: Fixed the completion tests and also added some logic so that typing a
:does not break completions. During that I noticed thaton:andlet:are suggested too often, for example also inside lambda functions of event handlers - should be looked into how we can solve this someday to not show in that case.Bumping the versions uncovered another error in svelte-preprocess with the new import transformation, need to check over at svelte-preprocess what the bug is. Edit: Found the issue over at svelte-preprocess (PR: sveltejs/svelte-preprocess#443), release pending, then we can continue here.