Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't load ambient worker types #8483

Merged
merged 1 commit into from Jan 13, 2023
Merged

fix: don't load ambient worker types #8483

merged 1 commit into from Jan 13, 2023

Conversation

dummdidumm
Copy link
Member

fixes #8268

Theoretically someone could have relied on us auto-loading the ambient types previously, but I doubt it because it means that adapter-cloudflare would have been imported somewhere where our tsconfig.json's include includes it (the svelte.config.js isn't), and you'd need to access cloudflare-specific things outside of platform. Getting the behavior back as a user is as easy as slapping /// <reference types="@cloudflare/workers-types" /> at the top of src/app.d.ts.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2023

🦋 Changeset detected

Latest commit: 3a98806

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 18a8c38 into master Jan 13, 2023
@Rich-Harris Rich-Harris deleted the cloudflare-types branch January 13, 2023 14:10
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-cloudflare@1.0.0-next.36 ambient.d.ts breaks DOM manipulation function types
2 participants