[feat] split Vite plugin in two #7990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aedc86b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Dec 8, 2022
|
I can't easily move them into separate functions, but I was able to declare them as variables first and then create the array which avoided the extra level of indentation, so hopefully that works |
5 tasks
Rich-Harris
approved these changes
Dec 8, 2022
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Storybook folks are currently working on Storybook 7 which has two nice improvements: you can use a Vite builder without installing Webpack at all and it has first-class support for SvelteKit! A wrinkle in the SvelteKit support is that SvelteKit runs in the same Vite instance and installs a middleware that ends up serving all the requests breaking the Storybook server. This splits the SvelteKit Vite plugin into two so that they can remove the middleware plugin - that way they still get the aliases and other things our plugin provides without taking over the whole server and breaking everything else.
This is arguably a breaking change if anyone is looking for
vite-plugin-svelte-kit, but hopefully no one is doing that. It's a bit of an implementation detail that we've never publicly documented or claimed would be stable