Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ActionData type - disallow undefined, allow null #7962

Merged
merged 3 commits into from Dec 7, 2022

Conversation

tcc-sejohnson
Copy link
Contributor

@tcc-sejohnson tcc-sejohnson commented Dec 6, 2022

Closes #7961. Prior art: #6994.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

🦋 Changeset detected

Latest commit: 3351698

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kit ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:19AM (UTC)
kit-svelte-dev ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 10:19AM (UTC)

@dummdidumm
Copy link
Member

Thanks for pointing out the inconsistency about undefined/null - there was indeed one situation where undefined could sneak in, where it shouldn't.

@dummdidumm
Copy link
Member

almost forgot, this also needs a changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActionData is defined as inferred | undefined but can actually be inferred | undefined | null
2 participants