Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ensure that editing app.html reloads open dev page #7944

Merged
merged 1 commit into from Dec 5, 2022

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Dec 5, 2022

fixes #7942

the vite client assumes that changes to html files should only trigger a full reload if they are named index.html and the path to the file matches the browser path. kit uses src/app.html by default which fails that check.

so we send another full-reload event to the client without a path - this forces it's hand.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

🦋 Changeset detected

Latest commit: 4452d92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit 5b276f2 into sveltejs:master Dec 5, 2022
@github-actions github-actions bot mentioned this pull request Dec 5, 2022
@lukaszpolowczyk
Copy link
Contributor

I understand correctly that this partially solves my rejected problem?
#6806 (comment)

Loading a package from node_modules still fails to load in app.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying the app.html HMR does not trigger a reload
5 participants