Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] rebuild manifest when client hooks or param matcher file is added/removed #7915

Merged
merged 2 commits into from Dec 2, 2022

Conversation

dummdidumm
Copy link
Member

In contrast to server hooks, client hooks are written to the client manifest and therefore need rebuilding when they are added/removed.

I noticed this while working on the tutorial

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

In contrast to server hooks, client hooks are written to the client manifest and therefore need rebuilding when they are added/removed
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

🦋 Changeset detected

Latest commit: 255422c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm changed the title [fix] rebuild manifest when client hook file is added/removed [fix] rebuild manifest when client hooks or param matcher file is added/removed Dec 2, 2022
@Rich-Harris Rich-Harris merged commit 78a2322 into master Dec 2, 2022
@Rich-Harris Rich-Harris deleted the client-hooks-rebuild-manifest branch December 2, 2022 14:36
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants