Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] correct Vite config merging with force option #7911

Merged
merged 1 commit into from Dec 2, 2022
Merged

Conversation

benmccann
Copy link
Member

two suggestions from @dominikg:

  • code was broken when force was used as we'd drop the other optimizeDeps options
  • we don't need our own config merge function as Vite has one that's exported

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

🦋 Changeset detected

Latest commit: f72a2ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 5963db0 into master Dec 2, 2022
@dummdidumm dummdidumm deleted the force-merge branch December 2, 2022 09:23
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants