Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass asset list to adapters #7667

Closed
wants to merge 1 commit into from
Closed

pass asset list to adapters #7667

wants to merge 1 commit into from

Conversation

Rich-Harris
Copy link
Member

had a quick look at #7640 to see if there's anything needed from the framework itself. i'm a little unclear on why requests are 404ing — it seems that the worker should be able to serve the assets, even if doing so is wasteful.

regardless, if we're not going to add all of written_files to the exclude array, then we probably need to pass the assets list (which contains all the files in the static folder) so that we can figure out which files were generated? not sure about any of this, so just going to leave this here in draft form for now

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

⚠️ No Changeset found

Latest commit: f02588e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member Author

going to close this until there's more clarity on requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant