Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set css: 'none' for SSR build #7590

Closed
wants to merge 3 commits into from
Closed

Set css: 'none' for SSR build #7590

wants to merge 3 commits into from

Conversation

Rich-Harris
Copy link
Member

Closes #7555. cc @dominikg — you good with us using experimental options in this context?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

🦋 Changeset detected

Latest commit: 264c236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/kit Patch
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

dummdidumm commented Nov 10, 2022

If this doesn't provide a gracious fallback for previous Svelte versions which do not understand this option, we need to bump the peerDependency, which makes this a breaking change.

@Rich-Harris
Copy link
Member Author

I'm not sure it matters anyway — this change breaks everything. We need the styles to be included in the ssr output, it turns out. Maybe we could get the styles from the csr build (but not in dev, because the csr components aren't guaranteed to be ready by the time we need them) but it's a lot of complexity for a very minor optimisation. Closing this and #7555

@benmccann benmccann deleted the gh-7555 branch November 10, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't generate CSS twice
2 participants