Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #7355

Merged
merged 12 commits into from Oct 29, 2022

Conversation

dominikg
Copy link
Member

It looks like renovate has not sent PRs for minor updates in a while, so this bumps them accross the board.

There is a test fail that seems to happen due to playwright waitForNavigation behaving differently than before, upon updating from 1.25.0 to 1.27 in vite-plugin-svelte I saw similar problems and worked around them by waiting for more specific events like the vite devserver connection.

Will try to investigate that tomorrow but wanted to see CI results.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2022

🦋 Changeset detected

Latest commit: 57a0bd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@sveltejs/adapter-auto Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
create-svelte Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

turbo.json Outdated
}
},
"globalDependencies": [".eslintrc.json", ".prettierrc", "tsconfig.json"]
"$schema": "https://turborepo.org/schema.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidental formatting (now has spaces instead of tabs)? Anything that actually changed in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was done by turbos migration tool and format didn't bother so I kept it that way. The code change is the way env dependencies are declared

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just checked what happens and it looks like prettier is never run from the root of the monorepo,

"format": "turbo run format",
this recursively calls format scripts in packages, but there is no separate format script in root so prettier is never called on root files.

i have formatted it manually with pnpm prettier --write turbo.json to keep the diff smaller here, but we should look into fixing this in a separate PR

@dominikg
Copy link
Member Author

no clue why it fails on mac only (4 times so it doesn't seem to be a coincidence). If anyone with a mac is able to reproduce that fail it would help.

@Rich-Harris
Copy link
Member

I can reproduce the failure locally. The test is expecting a console warning to appear, and it never does, but only when KIT_E2E_BROWSER=webkit.

The thing is the warning is visible in Safari devtools:

image

It looks like a new Playwright bug. Downgrading to 1.25 fixes it, at least locally — 🤞 for a full bank of green lights

@benmccann
Copy link
Member

It looks like Rich merged in my change to upgrade to Vite 3.2, but I'm not sure that we should since the Vite 3.2 types are borked so now lint won't pass on this PR

@Rich-Harris
Copy link
Member

I just merged master to resolve the conflicts. Are you saying we need to downgrade to Vite 3.1.something? Why are the types borked?

@benmccann
Copy link
Member

master isn't on Vite 3.2. It's on Vite 3.1. I sent #7400 to upgrade to 3.2.

3.2.1 fixed the types. You can either merge #7400 or upgrade this PR to 3.2.1

@benmccann benmccann merged commit e141513 into sveltejs:master Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants