Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] more info about prerendering errors and new strict option #7264

Merged
merged 10 commits into from Oct 18, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Oct 14, 2022

Helps with #7183 and #7244

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2022

🦋 Changeset detected

Latest commit: 02d41ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-static Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor tweaks

documentation/docs/13-page-options.md Outdated Show resolved Hide resolved
packages/kit/src/core/prerender/prerender.js Outdated Show resolved Hide resolved
@dummdidumm dummdidumm changed the title [fix] more info about prerendering errors [feat] more info about prerendering errors and new strict option Oct 17, 2022
const methods = new Set();

if (route.page) {
methods.add('SET');
methods.add('GET');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol oops

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small tweaks

packages/adapter-static/index.js Outdated Show resolved Hide resolved
packages/adapter-static/index.js Outdated Show resolved Hide resolved
packages/adapter-static/index.js Outdated Show resolved Hide resolved
packages/kit/src/core/prerender/prerender.js Outdated Show resolved Hide resolved
packages/kit/test/build-errors/prerender.spec.js Outdated Show resolved Hide resolved
@Rich-Harris Rich-Harris merged commit 4843de3 into master Oct 18, 2022
@Rich-Harris Rich-Harris deleted the prerendering-troubleshooting branch October 18, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants