Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: account for relative route path #7223

Merged
merged 5 commits into from Oct 12, 2022
Merged

Conversation

gbkwiatt
Copy link
Contributor

@gbkwiatt gbkwiatt commented Oct 11, 2022

Currently when using relative route path in config.kit.files.routes e.g. ../../project/src/routes sync fails because it generates types outside of .svelte-kit/types It should account for relative paths and generate them inside .svelte-kit/types

fixes: #7166

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Currently when using relative route path in `config.kit.files.routes` e.g. `../../project/src/routes` sync fails because it generates types outside of `.svelte-kit/types` 
It should account for relative paths and generate them inside `.svelte-kit/types`
@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2022

🦋 Changeset detected

Latest commit: 9b65038

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

dummdidumm commented Oct 11, 2022

Thanks! Could you add a changeset?

Also, to be sure: Does this really fix the mentioned issue completely? You talk about some manifest not being found there, and the changed code is only related to generating types.

@gbkwiatt
Copy link
Contributor Author

Thanks! Could you add a changeset?

Also, to be sure: Does this really fix the mentioned issue completely? You talk about some manifest not being found there, and the changed code is only related to generating types.

The issue was, if I wasn't using relative path for routes, sync was passing but build was failing due to wrong paths. But if I want to change routes path to match vite manifest (it always resolves to relative path), it was creating it in wrong place due to being relative and sync was filing and not creating route_meta_data.json. Fixing the sync solve it for that use case.

@dummdidumm dummdidumm merged commit 0fc2193 into sveltejs:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External routes failing on sync or build
2 participants