Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] remove vestigial JSON server_data #6382

Merged

Conversation

Conduitry
Copy link
Member

When we started serializing server data with devalue, the old JSON serialization of it was left in. This removes it.

This also updates the types so that server_data is no longer a valid type to pass to render_json_payload_script. This required a slight adjustment to the unit tests.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2022

🦋 Changeset detected

Latest commit: 8c571ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member Author

The difference with and without the extra server_data block can be seen on, for example https://kit.svelte.dev/docs/introduction and https://kit-svelte-di38rlap3-svelte.vercel.app/docs/introduction

@Rich-Harris
Copy link
Member

JFC these windows test timeouts are killing me. wtf is wrong with github actions

@Rich-Harris Rich-Harris merged commit 77d0f79 into sveltejs:master Aug 29, 2022
@Conduitry Conduitry deleted the remove-vestigial-json-server_data branch August 29, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants