Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] skip fetch caching if some server node was invalidated #6358

Closed
wants to merge 1 commit into from

Conversation

Tal500
Copy link
Contributor

@Tal500 Tal500 commented Aug 28, 2022

fixes #6357

and maybe also #6354 and #6349

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2022

🦋 Changeset detected

Latest commit: 2dc4faa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

thank you — this will be obsoleted by the changes in #6318, so I'll close this

@Tal500
Copy link
Contributor Author

Tal500 commented Aug 29, 2022

thank you — this will be obsoleted by the changes in #6318, so I'll close this

Glad to here!
Though I'm really afraid from the following line in the function load_data, which might be a nightmare for legacy support I'm working on... (or it should be easy, as long as the generated JS output is very simple, i.e. no ESModule stuff inside the dynamic generated script):

await import(/* @vite-ignore */ data_url.href);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidatation should always query the invalid server nodes with fetch({ cache: 'no-cache' })
2 participants