New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] encode if root layout has server load #6352
Conversation
🦋 Changeset detectedLatest commit: fecdac7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
||
// only include non-root layout/error nodes if they exist | ||
if (layouts.length > 0 || errors.length > 0) array.push(`[${layouts.join(',')}]`); | ||
array.push(`[${layouts.join(',')}]`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized, with the manifest adjustment the if that was there before can be reinstated
Fixes #6349
Fixes #6336
While fixing it I thought of ways to make the manifest shorter. I did that in a second commit so it can be reverted if not appropriate.
No test, I can't think of a way to test this without creating another test app, which I wanted to avoid - but can do so if we feel it's necessary.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0