Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename $app/env to $app/environment #6334

Merged
merged 6 commits into from Aug 27, 2022
Merged

rename $app/env to $app/environment #6334

merged 6 commits into from Aug 27, 2022

Conversation

Rich-Harris
Copy link
Member

closes #5715

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2022

🦋 Changeset detected

Latest commit: eb46574

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/kit Patch
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LukeHagar
Copy link
Contributor

$app/environment and not $app/flags or one of the other ideas?
environment feels very lateral but I don't hate it

@Rich-Harris Rich-Harris merged commit 9b50590 into master Aug 27, 2022
@Rich-Harris Rich-Harris deleted the gh-5715 branch August 27, 2022 14:20
Gingerbreadfork added a commit to Gingerbreadfork/svelte-themes that referenced this pull request Sep 8, 2022
notpushkin added a commit to notpushkin/svelte-spotlight that referenced this pull request Sep 15, 2022
notpushkin added a commit to notpushkin/svelte-spotlight that referenced this pull request Sep 15, 2022
Dilden added a commit to Dilden/vite-plugin-pwa that referenced this pull request Oct 5, 2022
`$app/env` was renamed to `$app/environment` on [PR#6334](sveltejs/kit#6334)
Jakeii added a commit to Jakeii/svelte-popdown that referenced this pull request Oct 28, 2022
BREAKING CHANGE: requires update to sveltekit as of sveltejs/kit#6334
Jakeii added a commit to Jakeii/svelte-popdown that referenced this pull request Oct 28, 2022
BREAKING CHANGE: requires update to sveltekit as of sveltejs/kit#6334
Jakeii added a commit to Jakeii/svelte-popdown that referenced this pull request Oct 28, 2022
BREAKING CHANGE: requires update to sveltekit as of sveltejs/kit#6334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename $app/env to $app/something
3 participants