Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong LayoutServerLoad.name type #6123

Merged
merged 2 commits into from Aug 20, 2022

Conversation

iceghost
Copy link
Contributor

@iceghost iceghost commented Aug 20, 2022

When you create only two files:

+layout-root.server.js
+layout-root.svelte

import("./$types").LayoutServerLoad.root is undefined. I guess it is due to a copy-paste typo.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2022

🦋 Changeset detected

Latest commit: 62f5711

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, thank you. Can you add a changeset? Then we can merge this

@iceghost
Copy link
Contributor Author

umm... yeah, let me try

@iceghost
Copy link
Contributor Author

@dummdidumm i added the changeset, thank you

@Rich-Harris Rich-Harris merged commit fc16ed3 into sveltejs:master Aug 20, 2022
@Rich-Harris
Copy link
Member

excellent, thank you!

@iceghost iceghost deleted the load-server-fix branch August 21, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working types / typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants