Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pattern matching for @ encoded routes #6110

Merged
merged 1 commit into from Aug 20, 2022

Conversation

trmcnvn
Copy link
Contributor

@trmcnvn trmcnvn commented Aug 20, 2022

Prior to this PR, if you had a route that started with an encoded @ symbol, it would not recognize the route because it split it based on the decoded @ symbol which is used for named layouts. This PR moves the decoding until after the split.

In the following setup, /@foo would not be accessible.

routes/
  %40foo/
    +page.svelte
  +page.svelte

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2022

🦋 Changeset detected

Latest commit: e3d61e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

this is excellent, thanks so much!

@Rich-Harris Rich-Harris merged commit ed013a9 into sveltejs:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants