Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use enumerable: false for temporary no-longer-exists getters #6105

Merged
merged 3 commits into from Aug 20, 2022

Conversation

Conduitry
Copy link
Member

There are a few objects in the codebase with getters that give more helpful errors messages that describe what features have replaced these removed/renamed features. However, these getters are also triggered when doing an object { ...spread }, which isn't very helpful. This updates these to use Object.definedProperties so that we may specify enumerable: false on these getters.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2022

🦋 Changeset detected

Latest commit: 1991257

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

this is to provide a load wrapper with a fetch that provides a base URL? that sounds handy and like something I would use and I've seen other people ask for. what do you think about adding that to the FAQ?

@Rich-Harris Rich-Harris merged commit b335f38 into sveltejs:master Aug 20, 2022
@Rich-Harris
Copy link
Member

@benmccann for fetch specifically, the intent was to let server-only load functions use the same fetch as shared load functions, so that specific case would no longer be necessary.

There are other times it would be useful to do this, but right now we're stymied by url being a getter:

get url() {
uses.url = true;
return load_url;
},

In #6056 I plan to replace that with a TrackedURL object that only triggers the dependency tracking on accessing things like pathname and toString (not origin or hostname, because those can't change), instead of url itself.

(parent is too, but it actually doesn't need to be — we only need to care about invocation, not access.)

There's also event.clientAddress, which I think we'll need to change to event.getClientAddress() so that we can promote patterns that use object spread (and also use it ourselves).

@Conduitry Conduitry deleted the enumerable-false branch August 20, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants