Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Undici" #5290

Closed
wants to merge 1 commit into from
Closed

Revert "Undici" #5290

wants to merge 1 commit into from

Conversation

Rich-Harris
Copy link
Member

Gah — we might need to revert #5117. undici doesn't implement multipart/form-data parsing, unlike node-fetch. Since that's the default encoding, this means that forms are basically broken as a result of the switch. We just didn't have any tests covering it.

Related issue: nodejs/undici#974

This reverts commit 7ed3c95.
@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022

⚠️ No Changeset found

Latest commit: a8d585a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member Author

closing in favour of #5292

@Conduitry Conduitry deleted the revert-5117-undici branch July 13, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant