Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] rename data-svelte to data-sveltekit #4641

Merged
merged 2 commits into from Apr 18, 2022
Merged

[chore] rename data-svelte to data-sveltekit #4641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e5621
[chore] rename data-svelte to data-sveltekit
benmccann Apr 16, 2022
46a7066
Create tiny-hounds-glow.md
Rich-Harris Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-hounds-glow.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
"@sveltejs/kit": patch
---

rename `data-svelte` attribute to `data-sveltekit`
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/client/client.js
View file
Open in desktop
Expand Up @@ -341,7 +341,7 @@ export function create_client({ target, session, base, trailing_slash }) {
function initialize(result) {
current = result.state;

const style = document.querySelector('style[data-svelte]');
const style = document.querySelector('style[data-sveltekit]');
if (style) style.remove();

page = result.props.page;
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/page/render.js
View file
Open in desktop
Expand Up @@ -206,7 +206,7 @@ export async function render_response({
} else {
if (inlined_style) {
const attributes = [];
if (options.dev) attributes.push(' data-svelte');
if (options.dev) attributes.push(' data-sveltekit');
if (csp.style_needs_nonce) attributes.push(` nonce="${csp.nonce}"`);

csp.add_style(inlined_style);
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/test/apps/basics/test/test.js
View file
Open in desktop
Expand Up @@ -1527,7 +1527,7 @@ test.describe.parallel('Page options', () => {
expect(await page.textContent('h1')).toBe('content was rendered');
} else {
expect(await page.evaluate(() => document.querySelector('h1'))).toBe(null);
expect(await page.evaluate(() => document.querySelector('style[data-svelte]'))).toBe(null);
expect(await page.evaluate(() => document.querySelector('style[data-sveltekit]'))).toBe(null);
}
});

Expand Down
4 changes: 2 additions & 2 deletions packages/kit/test/apps/options/test/test.js
View file
Open in desktop
Expand Up @@ -45,10 +45,10 @@ test.describe.parallel('base path', () => {
test('inlines CSS', async ({ page, javaScriptEnabled }) => {
await page.goto('/path-base/base/');
if (process.env.DEV) {
const ssr_style = await page.evaluate(() => document.querySelector('style[data-svelte]'));
const ssr_style = await page.evaluate(() => document.querySelector('style[data-sveltekit]'));

if (javaScriptEnabled) {
// <style data-svelte> is removed upon hydration
// <style data-sveltekit> is removed upon hydration
expect(ssr_style).toBeNull();
} else {
expect(ssr_style).not.toBeNull();
Expand Down