Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update vite-plugin-svelte #2626

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 18, 2021

Fixes #720

May address #2612 if experimental.prebundleSvelteLibraries works. I've tested this in a local production repo and it's working flawlessly.

vite-plugin-svelte also dropped support for node 12.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2021

🦋 Changeset detected

Latest commit: df0fc7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ignatiusmb
Copy link
Member

We might need to update Svelte core as well for the new enableSourcemap option

@bluwy bluwy marked this pull request as draft October 18, 2021 07:02
@bluwy
Copy link
Member Author

bluwy commented Oct 18, 2021

Waiting for sveltejs/vite-plugin-svelte#202 before it's ready (EDIT: It's ready)

@bluwy bluwy marked this pull request as ready for review October 18, 2021 07:50
@bluwy
Copy link
Member Author

bluwy commented Oct 18, 2021

Hmm, pnpm check is failing on Error: packages/kit check: ../../node_modules/.pnpm/vite@2.6.9/node_modules/vite/dist/node/index.d.ts(38,23): error TS7016: Could not find a declaration file for module 'ws'. '/home/runner/work/kit/kit/node_modules/.pnpm/ws@7.5.5/node_modules/ws/index.js' implicitly has an 'any' type. for both Vite 2.6.8 and 2.6.9. Note sure what happened there.

@bluwy
Copy link
Member Author

bluwy commented Oct 18, 2021

Looks like vitejs/vite#5273 may have brought extra types that weren't properly generated

@bluwy
Copy link
Member Author

bluwy commented Oct 18, 2021

I haven't had time to figure out a fix, but it seems to be an issue in Vite. I've reverted the commit for now.

@benmccann benmccann merged commit 7c88187 into master Oct 18, 2021
@benmccann benmccann deleted the update-vite-plugin-svelte branch October 18, 2021 15:10
@benmccann
Copy link
Member

I filed an issue in Vite regarding the types bug: vitejs/vite#5338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment variables in Svelte templates don't work with npm run build
3 participants