Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] explicitly add kit to ssr.noExternal #2306

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Conversation

ignatiusmb
Copy link
Member

Closes #2237

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2021

🦋 Changeset detected

Latest commit: 0dd95dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

We've been working on moving all the ssr.noExternal stuff from SvelteKit to vite-plugin-svelte actually.

I also have a PR out to Vite to fix this, which is probably the better way to go: vitejs/vite#4699

@ignatiusmb
Copy link
Member Author

It would be nice if we could be resolve the issue from our side first without waiting for upstream where we have no control, but delegating this to be handled on the plugin side would be nice too. Fixing it here or moving them to vite-plugin-svelte, and then updating it when upstream fixes it should be ideal either way.

@benmccann
Copy link
Member

yeah, makes sense

@benmccann benmccann merged commit e21892b into master Aug 28, 2021
@benmccann benmccann deleted the i2237/dev-deep-exports branch August 28, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module @sveltejs/kit/hooks in dev server
2 participants