add optimizeDeps.entries when build.rollupOptions.input is unspecified #2180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2137 removed the
optimizeDeps.entries
configuration added in #468. In most cases that's harmless, but I've experienced situations where Vite attempts to scan thousands of build artifacts in order to populateoptimizeDeps.include
, resulting in a crash. According to Vite's docs, it only does this whenrollupOptions.input
is unspecified. Since that's only true for the service worker build config, I've only re-added it there.Aside: I do not understand why prebundling is necessary. To me it feels like Vite should be able to say 'the browser is requesting
foo
fromnode_modules
, which appears to be suitable for prebundling, so lemme just run esbuild over it before responding'. I don't get why it has to happen eagerly.Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0