Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optimizeDeps.entries when build.rollupOptions.input is unspecified #2180

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

Rich-Harris
Copy link
Member

#2137 removed the optimizeDeps.entries configuration added in #468. In most cases that's harmless, but I've experienced situations where Vite attempts to scan thousands of build artifacts in order to populate optimizeDeps.include, resulting in a crash. According to Vite's docs, it only does this when rollupOptions.input is unspecified. Since that's only true for the service worker build config, I've only re-added it there.

Aside: I do not understand why prebundling is necessary. To me it feels like Vite should be able to say 'the browser is requesting foo from node_modules, which appears to be suitable for prebundling, so lemme just run esbuild over it before responding'. I don't get why it has to happen eagerly.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2021

🦋 Changeset detected

Latest commit: 733cf60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 995bc18 into master Aug 12, 2021
@Rich-Harris Rich-Harris deleted the optimize-deps-entries branch August 12, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant