Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly include ambient types from adapters #12088

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Apr 7, 2024

part of closing #11731

While investigating #11731 , I found that the ambient types from adapters weren't showing up when I tried installing the cloudflare, vercel, and node adapters in a fresh project and tried to access the autocomplete on event.platform.

This PR does the following:

* includes the svelte.config.js file in the generated tsconfig so that when the svelte.config.js file imports the adapter, the ambient types are included for the whole project. EDIT: separated into #12090

  • references the worker types in the cloudflare adapters so that when the adapter is used, the project can access those types.
  • standardises the naming of the files containing the internal adapter types and the ambient types we want included in the user's project when they add the adapter to the svelte config.
  • includes the vercel and node ambient types in the package.json files array.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added adapters - general Support for functionality general to all adapters pkg:adapter-vercel Pertaining to the Vercel adapter pkg:adapter-node pkg:adapter-cloudflare-workers pkg:adapter-cloudflare labels Apr 7, 2024
Copy link

changeset-bot bot commented Apr 7, 2024

🦋 Changeset detected

Latest commit: 595eb96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sveltejs/adapter-vercel Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Inclusion of the Svelte config was reverted in #11908 because it's a breaking change strictly speaking. Is it ok to hold off from doing this until 3.0?

@eltigerchino
Copy link
Member Author

eltigerchino commented Apr 7, 2024

Inclusion of the Svelte config was reverted in #11908 because it's a breaking change strictly speaking. Is it ok to hold off from doing this until 3.0?

Oh whoops. I didn’t realise it was something we already tried to do before.

Yeah, I think it’s fine to wait for 3.0 for this. It has an easy workaround (just include the types or reference the adapter in a declaration file). Maybe I can split the ambient declaration changes and the svelte config inclusion into separate PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants