Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add workerd condition to worker build #12069

Merged
merged 4 commits into from Apr 3, 2024

Conversation

mihar-22
Copy link
Contributor

@mihar-22 mihar-22 commented Apr 2, 2024

I was wrestling with an issue for one of our users as we couldn't get the Cloudflare build to bundle correctly. I noticed the conditions SvelteKit uses for bundling the Cloudflare Worker file was ['worker', 'browser']. We had workerd which was the documented condition that Wrangler uses. I thought this might be a better first condition then worker.

⚠️ I'd also add that I'm not sure if browser is a safe condition to include for the worker bundle. Browser code like window will throw and it's usually a compile-time check if (__BROWSER__) window.... Might be better to resort to things like server/node/default? We bundle our package with browser and then default for server files. Not sure what the standard here is, don't think one exists unfortunately or I haven't seen it.

Thanks!


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 26b4628

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

benmccann commented Apr 2, 2024

It looks like I originally added worker in #8083. I'm not sure why or where I got that from or if it's still needed

browser was then added shortly after in the next PR #8122

@benmccann
Copy link
Member

okay, it looks like workerd is a new thing and this PR is correct. It could be nice to link to what wrangler does. I've left comments for that. but besides that, this PR looks good to me

eltigerchino and others added 2 commits April 3, 2024 21:03
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@eltigerchino
Copy link
Member

Thank you!

@eltigerchino eltigerchino merged commit df6641a into sveltejs:main Apr 3, 2024
1 of 2 checks passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants