fix(netlify): fix conflict between Netlify Identity and edge function rendering #12052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Netlify Edge Functions didn't support a way to configure path matching that *excludes* paths. Now that it does, we can avoid running the "render" edge function on static assets. Currently, it's [just a no-op](https://github.com/sveltejs/kit/blob/80386437030c5c79913e859e3c32fd194613e1b6/packages/adapter-netlify/src/edge.js#L18-L22), but it's still nice to avoid the invocation.
🦋 Changeset detectedLatest commit: 5c3e74a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
serhalp
force-pushed
the
serhalp/fra-186-sveltekit-adapter-should-generate-edge-functions-that-dont
branch
from
e87b06a
to
5c3e74a
Compare
serhalp
commented
Mar 28, 2024
Comment on lines
+16
to
+17
| * TODO(serhalp) Replace this custom type with an import from `@netlify/edge-functions`, | ||
| * once that type is fixed to include `excludedPath` and `function`. |
There was a problem hiding this comment.
FYI I'm working on this as well. I should have a follow-up PR soon.
|
Hi @benmccann, nice to meet you! Is there anything I need to do to get this PR merged and released? Please let me know. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5235.
When using edge functions with Netlify, the generated edge function was configured to run against all paths. This conflicted with the expectation that paths under
.netlify/(such as.netlify/identity/settings) are ignored by the framework.At the time #5235 was opened, this was difficult to solve, but Netlify now supports path exclusions in edge function configuration, hence this PR.
While I was here, I also added an exclusion to avoid unnecessarily invoking this edge function on static files. Currently it's just a no-op, but it's still nice to avoid the unnecessary invocation.
Testing this is a bit involved, but I was able to repro the issue in #5235 and to confirm this fixes it. We should probably add proper integration tests here eventually.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits