Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle redirect thrown from root layout load when client-side navigating to a non-existent page #12005

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Mar 19, 2024

fixes #11099

There is currently no client-side error handling logic for when we run the root layout load function from rendering the root error page. This catches and handles the unhandled thrown Redirect.

Note: we should be displaying a static fallback page for any other type of error but I'm not sure how to do that client-side (the function already exists but only for the server).


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: 02933d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title fix: handle root layout redirect when navigating to a non-existent page in a SPA fix: handle universal root layout redirect for client-side navigation to a non-existent page Mar 19, 2024
@eltigerchino eltigerchino changed the title fix: handle universal root layout redirect for client-side navigation to a non-existent page fix: handle redirect thrown from root layout load when client-side navigating to a non-existent page Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPA Mode: Redirect from +layout.ts doesn't work on 404
1 participant