New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update pushState
function to reflect the new url in the page
store
#11994
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0bce072 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank for submitting this. Do you mind adding a test for it too? |
@Rich-Harris was it intended to be that way? |
Also updated the |
fixes #11492
The
pushState
function was not updating the built-inpage
store properties ($pages.url
and$pages.route
) even though the actual URL in the browser was changed. This causes changes to not reflected on the UI if a component depends on any of thosepage
store properties.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits