Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pushState function to reflect the new url in the page store #11994

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SunPodder
Copy link

@SunPodder SunPodder commented Mar 16, 2024

fixes #11492

The pushState function was not updating the built-in page store properties ($pages.url and $pages.route) even though the actual URL in the browser was changed. This causes changes to not reflected on the UI if a component depends on any of those page store properties.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 16, 2024

🦋 Changeset detected

Latest commit: 0bce072

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino
Copy link
Member

Thank for submitting this. Do you mind adding a test for it too?

@dummdidumm
Copy link
Member

@Rich-Harris was it intended to be that way?
I'd like to clarify this first before we merge this - this might be a feature, not a bug.

@SunPodder
Copy link
Author

Thank for submitting this. Do you mind adding a test for it too?

Also updated the replaceState function. Added tests for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replaceState in onMount does not update the $page store
4 participants