Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @zeabur/svelte-adapter support in adapter-auto #11939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yuaanlin
Copy link

@yuaanlin yuaanlin commented Mar 6, 2024

Introduce support for @zeabur/svelte-adapter in adapter-auto.

This PR simplifies the deployment process for developers aiming to host their Svelte applications on Zeabur.

It eliminates the need for manual installation and configuration updates, as outlined in the Zeabur documentation (https://zeabur.com/docs/guides/nodejs/svelte-kit#step-2-set-up-zeabursvelte-adapter).

Example Svelte Kit website deployed on Zeabur with @zeabur/svelte-adapter: https://svelte-kit.zeabur.app/


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: 8014fb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-auto Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

I've never particularly liked that this file is a kitchen sink for various adapters. I don't know if we want a giant list of relatively new and unknown hosting providers here. At the same time, it would be nice if adapter-auto didn't work only for the major players.

Perhaps we need a new way to handle this like process.env.SVELTEKIT_DEFAULT_ADAPTER and process.env.SVELTEKIT_DEFAULT_ADAPTER_VERSION could specify to download and use @zeabur/svelte-adapter version 1 and then we don't need to update this file whenever a new hosting provider would like to list their platform as they could provide those environment variables instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants