Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dts-buddy and typescript #11013

Closed
wants to merge 7 commits into from
Closed

bump dts-buddy and typescript #11013

wants to merge 7 commits into from

Conversation

Rich-Harris
Copy link
Member

The combination of bumping dts-buddy and bumping typescript seems to solve Rich-Harris/dts-buddy#34, which was worked around in c68d625. This means we can freely use import('types') in the codebase without it breaking declarations for users.

I don't think bumping the typescript major should have any downstream impacts, but someone please sanity check me.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 11, 2023

🦋 Changeset detected

Latest commit: 74f99d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bluwy
Copy link
Member

bluwy commented Nov 12, 2023

FWIW I also tried bumping typescript and dts-buddy recently 😬 It works and I don't think it breaks downstream, except that it allows us to use syntax that breaks downstream in the future. #10997 (comment)

@Rich-Harris
Copy link
Member Author

We don't use TypeScript syntax at all, so to me the risk seems low enough to not be worth worrying about

@Rich-Harris
Copy link
Member Author

the site build appears to be choking because it thinks this is JSX? i don't even know where to begin with this

parent(): Promise<ParentData>;

@benmccann
Copy link
Member

benmccann commented Dec 1, 2023

There's lots of merge conflicts here, so I'll go ahead and close this and make the change in #11160

@benmccann benmccann closed this Dec 1, 2023
@benmccann benmccann deleted the bump-dts-buddy branch December 1, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants