Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change cursor type to pointer on counter buttons (Sveltekit default template) #10161

Closed
wants to merge 2 commits into from
Closed

feat: change cursor type to pointer on counter buttons (Sveltekit default template) #10161

wants to merge 2 commits into from

Conversation

krishna-santosh
Copy link

closes #10160

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

🦋 Changeset detected

Latest commit: 9e10cbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@krishna-santosh krishna-santosh changed the title Feat/cursor pointer feat: change cursor type to pointer on counter buttons (Sveltekit default template) Jun 15, 2023
@gtm-nayan
Copy link
Contributor

tailwindlabs/tailwindcss#8961

@krishna-santosh
Copy link
Author

Closing this PR as changing the cursor type is not necessary when there's a clear indication (by background color change) that the button is clickable. Ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Cursor type in Counter (Sveltekit's default template)
2 participants