Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of async and import in comma expression #28

Merged
merged 4 commits into from Mar 26, 2024
Merged

Fix usage of async and import in comma expression #28

merged 4 commits into from Mar 26, 2024

Conversation

DimaIT
Copy link
Member

@DimaIT DimaIT commented Mar 25, 2024 •
edited

Fixes usage of async and import in comma expressions, like:

async = 1, b = 2;
b = 2, async = 1;
import.meta, 1;

Copy of meriyah/meriyah#254

@DimaIT DimaIT changed the title fix(parser): fix async assignment in comma expression Fix assignment to async in comma expression Mar 25, 2024
@DimaIT DimaIT changed the title Fix assignment to async in comma expression Fix usage of async and import in comma expression Mar 26, 2024
@DimaIT DimaIT requested review from qguv and ypapouski March 26, 2024 09:39
qguv
qguv approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@qguv qguv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! 👍

ypapouski
ypapouski approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@ypapouski ypapouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@qguv
Copy link
Collaborator

qguv commented Mar 26, 2024

Will you also send a PR upstream?

@DimaIT
Copy link
Member Author

DimaIT commented Mar 26, 2024

Will you also send a PR upstream?

It's already there :)

@DimaIT DimaIT merged commit 117e84c into master Mar 26, 2024
0 of 3 checks passed
@qguv qguv deleted the fix-async-assign branch March 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qguv qguv qguv approved these changes

@ypapouski ypapouski ypapouski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DimaIT @qguv @ypapouski