Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Tags and changepassword #164

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GlennPegdenFLT
Copy link

Fixed addition of DNS Tags (typo resulted in syntax error)

Removed createsuperuser, not only was it superfluous, so it always fails, but that failure means changepassword doesn't run, so the admin can never log in

syntax error)

Removed add user, not only was it supeflous, so it always fails,
but that failure means changepassword doesn't run, so the admin
can never log in
@gsilvapt
Copy link
Contributor

gsilvapt commented Feb 9, 2024

Thanks for your contribution, @GlennPegdenFLT. Can you confirm which version of Django you installed in your environment with pip list | grep Django? I'm asking because this used to work and maybe the API changed in Django 4. Just want to validate that's the case. It's strange though, it should create an admin user without password, forcing users to change it changepassword.

Alternatively, we can try without --noinput flag, which requires a user interaction to proceed.

As for the Tags fix - thanks, yes, that was a typo indeed.

@GlennPegdenFLT
Copy link
Author

I actually just came here to cancel the PR as I realised the changepassword part may be wrong (in fact, probably is wrong) as I was unintentionally using a mysql volume from an older install of surface (I'd assumed it was a clean install).

As you've spotted though, the tags part should still be valid though.

Sorry about that.

dev/box_setup.sh Outdated Show resolved Hide resolved
Signed-off-by: Gustavo Silva <gustavosantaremsilva@gmail.com>
@gsilvapt
Copy link
Contributor

I am unsure whether this permission error is because this is coming from a fork (and therefore you cannot push to the project's registry to avoid polluting with malicious code), or simply because of outdated actions. We will get back to this an upgrade all actions to rule out the issues - if needed, I'll reopen this change on my own PR - thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants