-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Integration model #109
base: main
Are you sure you want to change the base?
Conversation
I like the idea but not the implementation, in particular the hardcoded values in IMO it would be better if each "integration" app registered itself on init, similar to how the django apps already work. It could even be an extended version of AppConfig with metadata relevant for integrations. |
IntegrationType is not an important field, we can rely on the child name. I'll remove the field |
I was thinking to have an extended Integration model part of new django applications (if required) and match the application particularities with an extended list of fields. For instance, a new module named |
With this proposal I would like to dynamically manage the integrations at application level at any time after deployment not as an integration config at init phase. I'm trying to move away from the current approach which defines integration credentials as env vars to a more dynamic way of creating and managing integrations via UI |
As an example, https://github.com/surface-security/django-github uses Integration model as part of the |
somebody has a bit of free time to review this PR? |
Co-authored-by: Gustavo Silva <gustavosantaremsilva@gmail.com> Signed-off-by: Bogdan Oniga <bogdan@oniga.me>
Co-authored-by: Gustavo Silva <gustavosantaremsilva@gmail.com> Signed-off-by: Bogdan Oniga <bogdan@oniga.me>
Co-authored-by: Gustavo Silva <gustavosantaremsilva@gmail.com> Signed-off-by: Bogdan Oniga <bogdan@oniga.me>
Integration model is meant to be a base model for service integrations (e.g. AWS, GCP, etc.). It serves two main functions:
Each service integration has its own particularities and actions, therefore, this model will be inherited and extended per service integration's needs.