fp12_tower.c: add blst_bendian_from_fp12. #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See supranational#101 for details.
mratsim
reviewed
Feb 15, 2022
There was a problem hiding this comment.
I still think it's better to use the canonical representation instead of assuming Fp2 -> Fp6 -> Fp12 towering.
I found a paper mentioning it as well:
chapter 6.4
- Multiplication and Squaring on Pairing-Friendly Fields
Augusto Jun Devegili and Colm Ó hÉigeartaigh and Michael Scott and Ricardo Dahab, 2006
https://eprint.iacr.org/2006/471
And that's what I aimed for. What did I miss? Note that loops are in "inverse" order. I mean for non-canonical representation the outer loop would have 2 iterations... |
|
Friendly bump. |
|
Committed. Thanks for the feedback! And the bump ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #101 for details.