Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update kevinrob/guzzle-cache-middleware v4 #161

Closed
wants to merge 1 commit into from
Closed

fix(deps): update kevinrob/guzzle-cache-middleware v4 #161

wants to merge 1 commit into from

Conversation

ju5t
Copy link
Contributor

@ju5t ju5t commented Feb 21, 2022 •
edited by bytestream

Closes #160

@bytestream
Copy link
Member

Thanks.

Irritating - there's a phpstan bug...

------ ----------------------------------------------------------------------------- 
  Line   test/Cache/CacheableApisTest.php                                             
 ------ ----------------------------------------------------------------------------- 
  275    Reflection error: AnonymousClass8173b1ad570491d4329ae5dfc6ace63a not found.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols           
 ------ -----------------------------------------------------------------------------

@ju5t
Copy link
Contributor Author

ju5t commented Feb 21, 2022

Is it possible to ignore this line and skip it for now? Not sure if you're up for it though.

@bytestream
Copy link
Member

Nope. I've opened phpstan/phpstan#6681

@bytestream bytestream changed the title chore: update dependencies fix(deps): update kevinrob/guzzle-cache-middleware v4 Feb 25, 2022
@bytestream
Copy link
Member

bytestream commented Feb 25, 2022 •
edited

@ju5t I've handled phpstan and failing tests (#162), if you rebase this should work now. There's also no need for the changes to phpstan.neon

@bytestream
Copy link
Member

In fact, I've done it in #164

@bytestream bytestream closed this Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade kevinrob/guzzle-cache-middleware
2 participants
@ju5t @bytestream