Add ignore dependencies option in config file #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asakusuma
reviewed
Jun 9, 2021
3 tasks
added 4 commits
June 23, 2021 09:33
This will enable project to ignore libraries while running the supported tool
SparshithNR
force-pushed
the
ignored-deps
branch
from
23b4558
to
4c8df23
Compare
SparshithNR
changed the title
asakusuma
requested changes
Jun 23, 2021
SparshithNR
changed the title
asakusuma
reviewed
Jun 23, 2021
| @@ -38,6 +41,11 @@ async function main(cli, { policyDetails, setupProjectFn }) { | |||
| `The dependency ${dep} was found multiple times in the config file. Please refer Rules section in configuration.md`, | |||
| ); | |||
| } | |||
| if (ignoredDependencies.includes(dep)) { | |||
| throw new Error( | |||
| `The dependency ${dep} was found in ignoredDependencies and custom configuration. Please refer Rules section in configuration.md`, | |||
There was a problem hiding this comment.
this is fine for now, but once #36 lands, we should create a shortend url for it and actually show a url here for people to lookup
asakusuma
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will provide a way to enable config files to ignore dependencies. #36 has more information on this.
No CLI option to ignore dependencies for now.