Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help docs: updates to volumes and apps command help #3558

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

andie787
Copy link
Contributor

Change Summary

What and Why:

  • volumes and apps help needed a few updates/fixes

How:

  • remove "min 5" from snapshot retention help
  • clean up apps command help
  • make volumes help consistent

Related to:


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

`
short = "Manage apps"
long = "Manage your Fly applications."
short = "Manage apps."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what is our stance regarding period at the end of sentences but we recently saw this happening #3552

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok good to know thanks! the proposed style guide says to have a period for the short desc, but the way of least resistance might be to just go with whatever is already there 😆

Copy link
Contributor Author

@andie787 andie787 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dangra I looked at this again, and it doesn't make sense to remove the period from short descriptions for top level or sub-commands. Especially when the long desc is "short + more words". The PR you linked to is not a good change for this reason: https://fly.io/docs/flyctl/machine-clone/

Having no period for option descriptions is fine though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll have to either add periods to all of them, or stop using "short + ..." for long descriptions

@andie787 andie787 merged commit 9dee0d2 into master May 20, 2024
39 checks passed
@andie787 andie787 deleted the vol-apps-help branch May 20, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants