Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add trailing newline to usage template #2780

Merged
merged 1 commit into from Sep 1, 2023
Merged

add trailing newline to usage template #2780

merged 1 commit into from Sep 1, 2023

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Sep 1, 2023

Followup fix for #2733 for proper fly help output.

Note the original the default cobra UsageTemplate we used as a source includes a trailing newline:
https://github.com/spf13/cobra/blob/fd865a44e3c48afeb6a6dbddadb8a5519173e029/command.go#L567-L568

@wjordan
add trailing newline to usage template
19f84ef 
Followup fix for #2733 for proper `fly help` output.
michaeldwan
michaeldwan approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@michaeldwan michaeldwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@wjordan wjordan merged commit c912db5 into master Sep 1, 2023
37 checks passed
@wjordan wjordan deleted the usage-template-trailing-newline branch September 1, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldwan michaeldwan michaeldwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wjordan @michaeldwan