Adapt to deprecations in superfly/flyctl#2733 #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andie787
reviewed
Sep 4, 2023
apps/scale-count.html.markerb
Outdated
| @@ -324,4 +324,4 @@ If a Machine is misbehaving (for instance, it's not `stop`ping successfully), yo | |||
| fly machine destroy --force 0e286039f42e86 | |||
| ``` | |||
|
|
|||
| <div class="callout"> If you `destroy` a Machine, any volume that it had been using still exists until you either `fly volumes delete` it or `fly destroy` the Fly App it belongs to.</div> | |||
| <div class="callout"> If you `destroy` a Machine, any volume that it had been using still exists until you either `fly volumes delete` it or `fly apps destroy` the Fly App it belongs to.</div> | |||
There was a problem hiding this comment.
My preference would be not to use commands as verbs like this. In this case, remove the backticks from destroy in "If you destroy a Machine" and rewrite the rest something like "until you either delete the volume with the fly volumes delete command or delete the app the volume belongs to with the fly apps destroy command."
There was a problem hiding this comment.
Oh no! (not really oh no! I just prefer to use the command and backticks as I find it clearest)
There was a problem hiding this comment.
I tidied the callout. My reasoning here is that it's unnecessarily long to include all the commands.
catflydotio
commented
Sep 4, 2023
bradgessler
pushed a commit
that referenced
this pull request
Sep 29, 2023
* adapt to deprecations in superfly/flyctl#2733 * don't put nested commands in flyctl nav * Tidy callout language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick adaptation to recent flyctl changes (superfly/flyctl#2733). Replaces deprecated top-level commands with their
fly appsequivalents in docs, and removes deprecated commands from the flyctl nav.