Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Helm for checkov scans #5631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewkreuzer
Copy link

@andrewkreuzer andrewkreuzer commented May 9, 2024

Proposed changes

Includes Helm for the running of checkov scans with the helm framework

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco
Copy link
Collaborator

Hi @andrewkreuzer ! Thanks for this PR.

What problem are we solving here? :)

@andrewkreuzer
Copy link
Author

when running checkov using the "helm" framework I wasn't seeing scans being done for my helm charts. Running locally I was able to get the desired output:

helm scan results:
   Passed checks: 233, Failed checks: 0, Skipped checks: 0

but wasn't seeing this output with superlinter

Running checkov in the superlinter container checkov --framework helm --var-file my-values.yaml --directory charts I was able to get to this error:

2024-05-09 14:17:51,287 [MainThread  ] [ERROR]  There are no runners to run. This can happen if you specify a file type and a framework that are not compatible (e.g., `--file xyz.yaml --framework terraform`), or if you specify a framework with missing dependencies (e.g., helm or kustomize, which require those tools to be on your system). Running with LOG_LEVEL=DEBUG may provide more information.

@ferrarimarco
Copy link
Collaborator

I see, thanks for the details!

Copy link
Collaborator

@ferrarimarco ferrarimarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Besides this, we would need some test cases (good and bad ones) in this dir: https://github.com/super-linter/super-linter/tree/main/test/linters/checkov

Dockerfile Outdated Show resolved Hide resolved
scripts/install-helm.sh Outdated Show resolved Hide resolved
@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label labels May 9, 2024
@ferrarimarco ferrarimarco self-assigned this May 9, 2024
@ferrarimarco ferrarimarco added this to the 6.6.0 milestone May 9, 2024
@ferrarimarco
Copy link
Collaborator

One minor change: can you please make the test helm charts smaller? We don't need to have a fully working chart as a test case. What we need is the bare minimum to have tests pass :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants