Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect !inner in one-to-one relationships #530

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wyozi
Copy link
Contributor

@wyozi wyozi commented Apr 3, 2024

What kind of change does this PR introduce?

Select query type parser feature/bugfix

What is the current behavior?

.select("a_onetoone_rel!inner(*)")

results in a nullable a_onetoone_rel, while it should be non-nullable due to !inner

What is the new behavior?

Detects this case and removes nullability of the inner one-to-one relationship.

Additional context

non one-to-one case was fixed in #458

@wyozi
Copy link
Contributor Author

wyozi commented Apr 4, 2024

@steve-chavez this would be good to have merged, since otherwise #458 will behave very unexpectedly with !inner randomly not working on one-on-one relationships

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant