fix: explain() always returning an error #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sends `for="application/json"` as media type by default, instead of `for="undefined"`.
laurenceisla
force-pushed
the
fix-plan-mt
branch
from
abb643c
to
9ea1282
Compare
steve-chavez
approved these changes
Nov 18, 2023
|
🎉 This PR is included in version 1.8.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix. Closes #504
What is the current behavior?
Sends
"undefined"media type when requesting explain plan, making the explain() method fail.What is the new behavior?
Sends
"application/json"as media type.Additional context
Tests weren't failing because they were using PostgREST v11.0.0 instead of v11.2.2