feat: add storage.file_size_limit_bytes config #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds [storage] table to config.toml with a file_size_limit_bytes value that defaults to 50 MiB. This config value becomes the FILE_SIZE_LIMIT env var for the storage docker container. Fixes supabase#489
sweatybridge
requested changes
Oct 1, 2022
Pull Request Test Coverage Report for Build 3212624764
馃挍 - Coveralls |
grschafer
added a commit
to grschafer/supabase-cli
that referenced
this pull request
Oct 3, 2022
Suggested in PR review: supabase#494 (comment)
Suggested in PR review: supabase#494 (comment)
It seems preferable to transform a config file value (and throw any resulting errors) when parsing the config file, rather than waiting until we're starting up containers.
grschafer
force-pushed
the
add-storage-filesizelimit-config
branch
from
012e632
to
55afc8b
Compare
sweatybridge
changed the title
sweatybridge
approved these changes
Oct 9, 2022
sweatybridge
pushed a commit
that referenced
this pull request
Oct 9, 2022
Suggested in PR review: #494 (comment)
|
馃帀 This PR is included in version 1.7.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
Thanks for pushing this over the finish line! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Adds [storage] table to config.toml with a file_size_limit_bytes value that defaults to 50 MiB. This config value becomes the FILE_SIZE_LIMIT env var for the storage docker container.
What is the current behavior?
The storage-api's file size limit is hard-coded to 50 MiB and is not configurable.
This PR fixes #489
What is the new behavior?
The storage-api's file size limit can be configured in config.toml like below:
If the storage table or the file_size_limit_bytes key are not specified, the limit defaults to 50 MiB.
Additional context
I'm unfamiliar with Go, so please let me know if I did anything wrong! 馃榾