refactor: make pkce option a client setting #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-js into j0/add_global_pkce_option
thorwebdev
approved these changes
Apr 10, 2023
| private async _isPKCEFlow(): Promise<boolean> { | ||
| const currentStorageContent = await getItemAsync( | ||
| this.storage, | ||
| `${this.storageKey}-code-verifier` |
There was a problem hiding this comment.
Suggested change
| `${this.storageKey}-code-verifier` | |
| `${this.storageKey}-oauth-code-verifier` |
There was a problem hiding this comment.
Ah, good catch! Have renamed everything else to code-verifier instead so as to keep it generic
|
Leaving this with a refactor: prefix so semver doesn't trigger another release as I'd like to get another three PRs in
Upd: looks like refactor triggers a release too |
|
🎉 This PR is included in version 2.20.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor pkce to be a client setting so it doesn't have to be configured on invocation for each method.
exchangeSessionForCodein the background ifdetectSessionis enabledflowTypeoption from signInWithOAuth