Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: throw errors instead of strings #645

Merged
merged 2 commits into from
Apr 5, 2023
Merged

refactor: throw errors instead of strings #645

merged 2 commits into from
Apr 5, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Apr 4, 2023

see title

J0 added 2 commits April 5, 2023 00:19
@J0
refactors:
97cb95a 
convert strings which are thrown into errors
@J0
refactor: throw error instead of string
d7eba94
@J0 J0 requested review from kangmingtay and hf April 5, 2023 02:28
@J0 J0 merged commit 325d748 into master Apr 5, 2023
1 check passed
@J0 J0 deleted the J0/throw-errors-instead-of-strings branch April 5, 2023 02:28
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silentworks silentworks silentworks approved these changes

@thorwebdev thorwebdev Awaiting requested review from thorwebdev

@kangmingtay kangmingtay Awaiting requested review from kangmingtay

@hf hf Awaiting requested review from hf

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@J0 @silentworks