This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
fix(emacs-org): support content formats where headers aren't direct children of content #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,16 +113,16 @@ | |||
| } | |||
| } | |||
|
|
|||
| > h2 > .header-mark::before { | |||
There was a problem hiding this comment.
Hi @WolfeCub,
Can we use something like this?
> h2,
> h3,
> h4,
> h5,
> h6,
> .outline-text-2 > h2,
> .outline-text-3 > h3,
> .outline-text-4 > he,
> .outline-text-5 > h5,
> .outline-text-6 > h6,
{
> .header-mark::before {
content: "|";
margin-right: 0.3125rem;
}
}I think it's more performant to use child selectors instead of the descendant selectors.
| @@ -534,7 +534,7 @@ class Theme { | |||
| initHeaderLink() { | |||
| for (let num = 1; num <= 6; num++) { | |||
| this.util.forEach( | |||
| document.querySelectorAll(".single .content > h" + num), | |||
| document.querySelectorAll(".single .content h" + num), | |||
There was a problem hiding this comment.
If the proposed before will work for you, we can add here the new selector:
document.querySelectorAll(`.single .content > h${num}, .single .content > .outline-text-${num} > h${num}`)| content: "#"; | ||
| } | ||
| > h3 > .header-mark::before { |
There was a problem hiding this comment.
If the proposal will work, this would be the change:
> .outline-text-3 > h3 > .header-mark::before,
> h3 > .header-mark::before {
/* ... */
}
victor-pogor
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
.orgfiles as a content format each header generates a container around the text that follows it. Example:Due to the way the styles and selectors are implemented currently this breaks header marks since they are required to be direct children of content.
I propose simply allowing any nested children of content that have headers to be given header marks.