improve error messages on parse errors #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see lovasoa/SQLpage#275 (comment) error messages not specifying what the error is make it hard to debug the problem this also renames some grammar rules to make them easier to understand
|
LGTM. Thank you @lovasoa |
|
Great, thank you! Could you release a new version on crates.io ? |
|
Sure. Just released it as 5.1.2 |
|
Great, 5.1.2 will be in SQLPage's next version ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an user report being unable to debug a template syntax error, because the error message just said "invalid handlebars syntax" without more details: lovasoa/SQLpage#275 (comment)
This changes syntax error messages to include the precise source of the syntax error
this also renames some grammar rules to make them easier to understand